RFR: 8328307: GenShen: Re-enable old-has-grown trigger for old-generation GC [v5]

[Y. Srinivas Ramakrishna]

On Mon, 1 Apr 2024 15:26:49 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix another typo
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 3202:
> 
>> 3200: 
>> 3201:   if (mode()->is_generational()) {
>> 3202:     ShenandoahGenerationalHeap* gen_heap = (ShenandoahGenerationalHeap*) this;
> 
> May be `ShenandoahGenerationalHeap::heap()` like was done further above? (subjective nit can be ignored; see another suggestion further below that affects this as well.)

The object on which the method is called could keep a reference to the generational heap to avoid the need to pass it as an argument in the call. (In particular, do the heuristics objets -- if these methods were to move there -- keep a reference to the heap and to the appropriate generations?)

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/409#discussion_r1546476345