RFR: 8324649: Shenandoah: refactor implementation of free set [v32]

[Y. Srinivas Ramakrishna]

On Wed, 20 Mar 2024 19:52:55 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 41:
>> 
>>> 39: 
>>> 40: 
>>> 41: // ShenandoahSimpleBitMap resembles CHeapBitMap but adds missing support for find_next_consecutive_bits() and
>> 
>> Ah I see you have considered using bitMap.* ... but why not 'simply' add the required methods there, instead?
>
> Was trying to avoid impacting beyond the boundaries of Shenandoah.  I can tackle this if we think it preferable.  But also trying to work toward "timely integration".

Like Roman, I'd prefer extending existing code and/or making it adaptable for our purposes to duplicating functionality. Let us read through the differences and see if this should be done now, or as you state allow this duplication for now in the interests of speed and expediency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1546513139