RFR: 8329332: Remove CompiledMethod and CodeBlobLayout classes [v2]
Vladimir Kozlov
kvn at openjdk.org
Wed Apr 3 19:59:01 UTC 2024
On Wed, 3 Apr 2024 17:50:15 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> No special rules here. I simply want to see all `virtual` methods explicitly and `override` is required by C++.
>> I would like to keep it this way in these changes. I am investigating possibility to convert all these virtual methods to normal one to remove virtual table and virtual pointer (8 bytes) from CodeBlob class.
>
> `override` is not required by C++. You do however mark all virtual methods with `override` if any of the functions are marked with `override`. I think it would be good to have a HotSpot code style discussion about this (but not in this RFE).
I put `virtual/override` cleanup in CodeBlob as additional suggestion in followup RFE JDK-8329628.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18554#discussion_r1550370826
More information about the shenandoah-dev
mailing list