RFR: JDK-8241503: C2: Share MacroAssembler between mach nodes during code emission [v12]

Boris Ulasevich bulasevich at openjdk.org
Wed Apr 10 21:24:47 UTC 2024


On Tue, 9 Apr 2024 19:10:30 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> # Description
>> 
>> Please review this PR with a patch to re-use the same C2_MacroAssembler object to emit all instructions in the same compilation unit.
>> 
>> Overall, the change is pretty simple. However, due to the renaming of the variable to access C2_MacroAssembler, from `_masm.` to `masm->`, and also some method prototype changes, the patch became quite large.
>> 
>> # Help Needed for Testing
>> 
>> I don't have access to all platforms necessary to test this. I hope some other folks can help with testing on `S390`, `RISC-V` and `PPC`.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix ARM32 AD file

src/hotspot/cpu/arm/arm.ad line 1877:

> 1875: %}
> 1876: 
> 1877: // Pointer Immediate

Why do you introduce immN operands for arm32?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16484#discussion_r1560068373


More information about the shenandoah-dev mailing list