RFR: 8330071: GenShen: Allow old to expand again at end of each GC [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Thu Apr 11 19:58:53 UTC 2024
On Thu, 11 Apr 2024 16:12:42 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> This corrects errors in the implementations of max_size_for(OLD) and min_size_for(OLD). These errors were preventing expansion of OLD in preparation for subsequent mixed-evacuation cycles.
>
> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>
> Spelling errors in comment
What would go wrong if, as indicated in your comments, you were to return `heap - min_young` for `max(old)`, and `heap - max_young` for `min(old)` ?
If nothing would go wrong, why not do that? If something would go wrong if one did that, may be that needs to be documented along with the comment you added.
-------------
PR Review: https://git.openjdk.org/shenandoah/pull/421#pullrequestreview-1995160319
More information about the shenandoah-dev
mailing list