RFR: 8329789: GenShen: Over assertive assert when scanning remembered set [v2]

Y. Srinivas Ramakrishna ysr at openjdk.org
Thu Apr 11 20:10:54 UTC 2024


On Thu, 11 Apr 2024 17:08:16 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.inline.hpp line 776:
>> 
>>> 774: 
>>> 775:       // If we are using the write table (during update refs, e.g.), a mutator may dirty
>>> 776:       // a card at any time. This is fine for the algorithm below because it is only
>> 
>> Didn't finish your thought in this comment.
>
> Hmm, strange. Fixed it.

The weakening of the assert and the explanatory comment look good to me; thanks!

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/418#discussion_r1561586603


More information about the shenandoah-dev mailing list