RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v2]

Stefan Karlsson stefank at openjdk.org
Fri Apr 12 07:04:44 UTC 2024


On Thu, 11 Apr 2024 16:40:59 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 4684:
>> 
>>> 4682:   char* hint = (char*)(os::Linux::initial_thread_stack_bottom() -
>>> 4683:                        (StackOverflow::stack_guard_zone_size() + page_size));
>>> 4684:   char* codebuf = os::attempt_reserve_memory_at(hint, page_size, false, mtInternal);
>> 
>> Should these be `mtInternal` or is there a `mtStack` that is more suitable?
>
> In line 4699, a few lines later, the original developer used `mtInternal`. I copied it here too.

OK. Then this is fine for now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1562106768


More information about the shenandoah-dev mailing list