RFR: 8329790: GenShen: Old regions that are pinned during final mark are not made parseable [v2]

[Kelvin Nilsen]

On Sat, 6 Apr 2024 00:39:27 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.cpp line 327:
>> 
>>> 325:     live_data += live_bytes;
>>> 326: 
>>> 327:     if (region->is_trash()) {
>> 
>> In revised code structure, we handle trash regular regions with same code that handles trash humongous regions.  I like this improvement.  This is a note to self.  Please let me know if I am misunderstaning.
>
> Need to double-check myself here.  is_trash() may not be exactly the same as !region->has_live().  If these are distinct, maybe we want to check for either condition right here.

I see that we need to explicitly make_trash() after we discover that !region->has_live().  So these are different conditions.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/420#discussion_r1559616445