RFR: 8329790: GenShen: Old regions that are pinned during final mark are not made parseable [v2]

[Kelvin Nilsen]

On Mon, 15 Apr 2024 16:15:45 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.cpp line 332:
>> 
>>> 330:       immediate_garbage += garbage;
>>> 331:     } else if (region->is_humongous_start()) {
>>> 332:       // This will handle humongous start regions whether they are also pinned, or not.
>> 
>> Since we've already handled region->is_trash() above, do we need this code?  If we want to preserve the assert(!is_pinned), we can insert that into the is_trash() code above.  Right?
>
> I didn't change the implementation of `is_humongous_start`, so it still includes pinned humongous objects.

My question was misguided.  Ignore it.  (I was confused when I was first reading this PR.)

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/420#discussion_r1566090417