RFR: 8324649: Shenandoah: replace implementation of free set [v43]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Apr 17 16:13:07 UTC 2024


On Tue, 9 Apr 2024 19:32:08 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation of function declaration
>
> src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 915:
> 
>> 913: public:
>> 914:   ShenandoahPostCompactClosure() : _heap(ShenandoahHeap::heap()), _live(0) {
>> 915:     _heap->free_set()->clear();
> 
> Why is that ok?

There is no need to clear() because prepare_to_rebuild() invokes clear_internal() before it establishes new partition assignments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1569103078


More information about the shenandoah-dev mailing list