RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v4]

[Stefan Karlsson]

On Mon, 15 Apr 2024 16:02:01 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/memory/virtualspace.hpp line 199:
>> 
>>> 197:   size_t _upper_alignment;
>>> 198: 
>>> 199:   MEMFLAGS _nmt_flag;
>> 
>> The VirtualSpace::initialize functions used to initialize these members in the order that they are specified here. That is now messed up by adding the _nmt_flag at the end here, but in the beginning in the initialize function. I would propose that you move it to after _executable, both here and in the initialize function.
>
> Fixed.

I'd like to see some consistency between ReservedHeap and VritualSpace. Could you change the variables layout and intialization to be:

_special
_executable
_nmt_flags

in both classes?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1570369399