RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v8]

[Afshin Zafari]

On Thu, 18 Apr 2024 09:36:59 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   order of params are consistent now. style is corrected.
>
> src/hotspot/share/runtime/os.cpp line 2185:
> 
>> 2183: char* os::map_memory(int fd, const char* file_name, size_t file_offset,
>> 2184:                      char *addr, size_t bytes,
>> 2185:                      bool read_only, bool allow_exec, MEMFLAGS flags) {
> 
> You should probably move back read_only to the line below.

move back means line above?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1570806464