RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v10]

Afshin Zafari azafari at openjdk.org
Fri Apr 19 08:18:00 UTC 2024


On Fri, 19 Apr 2024 06:40:35 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more improvements in style/alignments/adjustments.
>
> src/hotspot/share/runtime/os.hpp line 232:
> 
>> 230:   static char*  pd_map_memory(int fd, const char* file_name, size_t file_offset,
>> 231:                               char *addr, size_t bytes,
>> 232:                               bool read_only = false, bool allow_exec = false);
> 
> I'd like to see this reverted.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1572006493


More information about the shenandoah-dev mailing list