RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v12]

Afshin Zafari azafari at openjdk.org
Fri Apr 19 09:49:34 UTC 2024


On Fri, 19 Apr 2024 09:31:12 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   local/param `flags` renamed to `alloc_type` to let have `MEMFLAGS flag` param.
>
> src/hotspot/share/memory/virtualspace.cpp line 709:
> 
>> 707:   assert(max_commit_granularity > 0, "Granularity must be non-zero.");
>> 708: 
>> 709: 
> 
> This blankline should be reverted.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1572118687


More information about the shenandoah-dev mailing list