RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v7]

[Afshin Zafari]

On Tue, 23 Apr 2024 09:02:49 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> David is right, this comment wasn't addressed. The code here went back and forth and we settled on hiding `ReservedMemoryRegion(address base, size_t size)` in a separate RFE. This means we probably should revert the usage of `flag` here and all the places that passes down `flag` just to reach this function.
>
> We discussed that having flag here, we can use it for checking if the requested flag matches the actual memory flag or not. This check is missed now. 
> What to do? reverting all the calls up to `os::uncommit_memory()`? and reverting the `ExecMem` param as optional?
> 
> Or adding check of flags?

New info:
I added the check and it always failed, meaning that no uncommit flag matches with commit flag.
I will remove the mandatory flag from uncommit, but it hides the issue of non-matching commit-uncommit flags.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1576156475