RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v13]

[Thomas Stuefe]

On Tue, 23 Apr 2024 08:56:55 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp line 262:
>> 
>>> 260:     vm_exit_out_of_memory(word_size * BytesPerWord, OOM_MMAP_ERROR, "Failed to reserve memory for metaspace");
>>> 261:   }
>>> 262:   MemTracker::record_virtual_memory_type(rs.base(), mtMetaspace);
>> 
>> Looking at this, I don't particularly like it, but it is pre-existing. The fact that we hard-wire mtMetaspace works now relies on the fact that mtClass and mtMetaspace (as of now, the only two flags that are being used) are using different allocation paths. Long term we should change this.
>
> Should I create a RFE for it?

Sure, go ahead. You can assign this to me, if you want.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1576572430