RFR: 8324649: Shenandoah: replace implementation of free set [v45]
Kelvin Nilsen
kdnilsen at openjdk.org
Tue Apr 30 03:12:41 UTC 2024
On Tue, 23 Apr 2024 17:01:18 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix typo
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 365:
>
>> 363: assert (idx < _max, "index is sane: " SIZE_FORMAT " < " SIZE_FORMAT, idx, _max);
>> 364: ShenandoahFreeSetPartitionId result = ShenandoahFreeSetPartitionId::NotFree;
>> 365: for (uint partition_id = 0; partition_id < NumPartitions; partition_id++) {
>
> Looks to me like you could just call the below membership() method (and make membership() available outside of ASSERT), and then pass the result to partition_name()?
Thanks. I'll make this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1584071528
More information about the shenandoah-dev
mailing list