RFR: 8324649: Shenandoah: replace implementation of free set [v45]
Kelvin Nilsen
kdnilsen at openjdk.org
Tue Apr 30 03:44:42 UTC 2024
On Tue, 23 Apr 2024 17:17:30 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix typo
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 906:
>
>> 904: }
>> 905:
>> 906: r->set_update_watermark(r->bottom());
>
> Why is that here? It means we would update-refs in this humongous object, but why is it needed in a new object?
Good catch. I suspect this code was accidentally introduced by GenShen engineers before we had a good grasp of the update_watermark role. I'm removing this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1584090307
More information about the shenandoah-dev
mailing list