RFR: 8330076: [NMT] add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v7]

[Thomas Stuefe]

On Thu, 18 Apr 2024 08:39:46 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/classfile/compactHashtable.cpp line 243:
>> 
>>> 241:     quit("Unable to open hashtable dump file", filename);
>>> 242:   }
>>> 243:   _base = os::map_memory(_fd, filename, 0, nullptr, _size, mtInternal, true, false);
>> 
>> Isn't this CDS code. Should ths be mtClassShared or something else that indicates that this is CDS code?
>
> Fixed.

I don't see the fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1584163987