RFR: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API [v7]

Stefan Karlsson stefank at openjdk.org
Tue Apr 30 13:35:16 UTC 2024


On Tue, 30 Apr 2024 12:03:47 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Do you mean to move the initializations on line 57 (and others in the files) to the `initialize` method?
>
> Or, just remove it. The initialise function already initialises the member, right?
> 
> But it's really a small nit. I like your variant more if it were uniquely applied.

FWIW, in an earlier comment I also mentioned that we really should take a pass over this class and clean the code in various ways.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18745#discussion_r1584830726


More information about the shenandoah-dev mailing list