RFR: 8338202: Shenandoah: Improve handshake closure labels
Roman Kennke
rkennke at openjdk.org
Mon Aug 12 16:23:31 UTC 2024
On Mon, 12 Aug 2024 13:47:28 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Currently, Shenandoah has a few handshakes that have not very clear names, "ShenandoahRendezvous". Would be good to make them more explicit.
>
> Before:
>
>
> Event: 2.593 Executing VM operation: Shenandoah Init Marking
> Event: 2.594 Executing VM operation: Shenandoah Init Marking done
> Event: 2.599 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB Handshake)
> Event: 2.599 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB Handshake) done
> Event: 2.599 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB Handshake)
> Event: 2.599 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB Handshake) done
> Event: 2.599 Executing VM operation: Shenandoah Final Mark and Start Evacuation
> Event: 2.600 Executing VM operation: Shenandoah Final Mark and Start Evacuation done
> Event: 2.600 Executing VM operation: HandshakeAllThreads (ShenandoahRendezvous)
> Event: 2.600 Executing VM operation: HandshakeAllThreads (ShenandoahRendezvous) done
> Event: 2.604 Executing VM operation: HandshakeAllThreads (ShenandoahRendezvous)
> Event: 2.604 Executing VM operation: HandshakeAllThreads (ShenandoahRendezvous) done
> Event: 2.605 Executing VM operation: CleanClassLoaderDataMetaspaces
> Event: 2.606 Executing VM operation: CleanClassLoaderDataMetaspaces done
> Event: 2.606 Executing VM operation: Shenandoah Init Update References
> Event: 2.606 Executing VM operation: Shenandoah Init Update References done
> Event: 2.611 Executing VM operation: HandshakeAllThreads (Shenandoah Update Thread Roots)
> Event: 2.611 Executing VM operation: HandshakeAllThreads (Shenandoah Update Thread Roots) done
> Event: 2.611 Executing VM operation: Shenandoah Final Update References
> Event: 2.611 Executing VM operation: Shenandoah Final Update References done
>
>
> After:
>
>
> Event: 1.043 Executing VM operation: Shenandoah Init Marking
> Event: 1.044 Executing VM operation: Shenandoah Init Marking done
> Event: 1.050 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB)
> Event: 1.050 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB) done
> Event: 1.050 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB)
> Event: 1.050 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB) done
> Event: 1.050 Executing VM operation: Shenandoah Final Mark and Start Evacuation
> Event: 1.050 Executing VM operation: Shenandoah Final Mark and Start Evacuation done
> Event: 1.051 Executing VM operation: HandshakeAllThreads (Shenandoah Concurrent Weak...
Looks good to me, thank you!
-------------
Marked as reviewed by rkennke (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20549#pullrequestreview-2233517305
More information about the shenandoah-dev
mailing list