RFR: 8336742: Shenandoah: Add more verbose logging/stats for mark termination attempts [v4]
Aleksey Shipilev
shade at openjdk.org
Tue Aug 13 16:24:03 UTC 2024
On Tue, 13 Aug 2024 16:17:53 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Neethu Prasad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address feedback on code style
>
> src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp line 60:
>
>> 58: SHENANDOAH_PAR_PHASE_DO(conc_mark_roots, " CMR: ", f) \
>> 59: f(conc_mark, "Concurrent Marking") \
>> 60: f(conc_mark_satb_flush_rendezvous, " SATB Flush Rendezvous") \
>
> Could this be "Flush SATB" or "Flush SATB Handshakes" for consistency with https://github.com/openjdk/jdk/pull/20549?
`Flush SATB` would be good, I think.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20318#discussion_r1715581820
More information about the shenandoah-dev
mailing list