RFR: 8337563: NMT: rename MEMFLAGS to MemFlag

Gerard Ziemski gziemski at openjdk.org
Tue Aug 13 16:32:49 UTC 2024


On Tue, 13 Aug 2024 01:16:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>> 
>> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemType` is much more suitable name.
>> 
>> There is a bunch of other related cleanup that we can do, but I will leave for follow up issues such as [NMT: rename NMTUtil::flag to NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836)
>
> MemType still makes all the "flag" variable names look weird IMO.

@dholmes-ora @tstuefe @jdksjolen

Is everyone OK with MemTypeFlag?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2286658061


More information about the shenandoah-dev mailing list