RFR: 8293650: Shenandoah: Support archived heap objects [v3]

[Aleksey Shipilev]

On Tue, 13 Aug 2024 17:41:13 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Review comments
>>  - Merge branch 'master' into JDK-8293650-shenandoah-archives
>>  - Move constant to separate class to unbreak Windows builds
>>  - Touchups in test
>>  - Basic implementation, works well, passes tests
>
> src/hotspot/share/cds/archiveHeapWriter.hpp line 126:
> 
>> 124:   // depends on -Xmx, but can never be smaller than 1 * M.
>> 125:   // (TODO: Perhaps change to 256K to be compatible with Shenandoah)
>> 126:   static constexpr int MIN_GC_REGION_ALIGNMENT = 1 * M;
> 
> Couldn't you just move up the constant to the public section?
> Also, I'm not sure what's the point of it being constexpr (rather that just const), but that is pre-existing.

Yeah, I had problems with that. But I think I just misplaced the constant the last time around. Let me see what Windows GHA runs have to say about the code in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20468#discussion_r1715839754