RFR: 8338341: GenShen: Cleanup headers, unreachable code and unintentional changes

[Y. Srinivas Ramakrishna]

On Tue, 13 Aug 2024 23:49:12 GMT, William Kemper <wkemper at openjdk.org> wrote:

> This PR covers a number of small changes to address comments on https://github.com/openjdk/jdk/pull/20395

src/hotspot/share/gc/shared/gcConfiguration.cpp line 75:

> 73: 
> 74:   if (UseShenandoahGC) {
> 75:     return Shenandoah;

@earthling-amzn : Here and at lines 47-52, don't we want to return, much like Gen ZGC does, the (new) values `ShenandoahMinor` and `ShenandoahMajor` -- or ShYoung and ShOld, or ShNew and ShOld, as one prefers -- for the young and old collectors, respectively, in the generational case, and just Shenandoah for both cases in the non-generational case?

Where are the `GCConfiguration::*_collector()` APIs called from?

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/468#discussion_r1716345931