RFR: 8293650: Shenandoah: Support archived heap objects [v4]

[Aleksey Shipilev]

On Wed, 14 Aug 2024 16:53:40 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Work around 32-bit build failure
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 2509:
> 
>> 2507:   // Pull the constant here, since it is only available when INCLUDE_CDS_JAVA_HEAP is defined.
>> 2508:   const size_t min_gc_region_align = 1 * M;
>> 2509: #if INCLUDE_CDS_JAVA_HEAP
> 
> It makes me wonder if the whole body should perhaps go inside the INCLUDE_CDS_JAVA_HEAP block. It is only ever called from ArchiveHeapLoader, and that doesn's even exist without INCLUDE_CDS_JAVA_HEAP. I leave that up to you.

That should actually be cleaner. Let's see what 32-bit builds say.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20468#discussion_r1717308901