RFR: 8337563: NMT: rename MEMFLAGS to MemFlag
Kim Barrett
kbarrett at openjdk.org
Thu Aug 15 08:01:51 UTC 2024
On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemType` is much more suitable name.
>
> There is a bunch of other related cleanup that we can do, but I will leave for follow up issues such as [NMT: rename NMTUtil::flag to NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836)
The suggestion of "nmtGC" from @daholmes initially looked somewhat appealing
to me. But that then suggests "NMTType" or (better?) "NMTGroup" or something
like that. But I don't much like the look of or typing those acronyms. (Note
that NMTGroup is HotSpot style, not NmtGroup.)
So I'm still preferring "MemType".
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2290847405
More information about the shenandoah-dev
mailing list