RFR: 8338477: GenShen: Cleanup generational heap

Kelvin Nilsen kdnilsen at openjdk.org
Mon Aug 19 19:34:11 UTC 2024


On Fri, 16 Aug 2024 21:53:17 GMT, William Kemper <wkemper at openjdk.org> wrote:

> * Inline heap accessor
> * break up huge do_work method
> * remove TODOs

Marked as reviewed by kdnilsen (Committer).

src/hotspot/share/gc/shenandoah/shenandoahGenerationalHeap.cpp line 321:

> 319:   if (result == copy_val) {
> 320:     // Successfully evacuated. Our copy is now the public one!
> 321:     ContinuationGCSupport::relativize_stack_chunk(copy_val);

I don't remember the significance of relative_stack_chunk().  Should we have a comment to explain what this is doing?

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/474#pullrequestreview-2246304716
PR Review Comment: https://git.openjdk.org/shenandoah/pull/474#discussion_r1722254382


More information about the shenandoah-dev mailing list