RFR: 8338717: GenShen: Fix up some assertions

[William Kemper]

On Wed, 21 Aug 2024 08:17:34 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

> In https://github.com/openjdk/jdk/pull/20395 Aleksey provided some suggestions for improving various assertions. This ticket gathers together several of those changes.
> 
> **Testing:**
> - [x] GHA
> - [x] jtreg:tier1
> - [ ] Codepipeline (investigating what appears to be an unrelated failure I encountered in testing)
> - [ ] SPECjbb w/GenShen (in progress)

Marked as reviewed by wkemper (Committer).

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/478#pullrequestreview-2251549798