RFR: 8338535: GenShen: some style improvements to source code implementation [v3]

[Kelvin Nilsen]

On Tue, 20 Aug 2024 08:58:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code touchup
>>   
>>   Remove 2 unneeded blank lines
>>   Move and simplify a comment from call point to called method
>>   implementation
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.hpp line 73:
> 
>> 71: 
>> 72:   virtual void choose_collection_set_from_regiondata(ShenandoahCollectionSet* cset,
>> 73:                                                      RegionData data[], size_t size,
> 
> Not at all sure this is a great style. It is also not consistent with the rest of Hotspot: searching for `[],` or `[] ` in `.cpp` files yields no hits. Leave it be at `RegionData*`.

Will revert these changes.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/475#discussion_r1725703307