RFR: 8338535: GenShen: some style improvements to source code implementation [v5]

[William Kemper]

On Wed, 21 Aug 2024 20:34:47 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> 1. Hide union data structure behind accessor methods for ShenandoahHeuristics::RegionData._u
>> 2. Change type of ShenandoahCollectionSet::establish_preselected from byte* to byte[] to clarify intended usage.
>> 3. Remove unhelpful comment from shenandoahFullGC.cpp
>
> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix whitespace

Changes requested by wkemper (Committer).

src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.hpp line 39:

> 37:   friend class ShenandoahCollectionSetPreselector;
> 38: 
> 39:   void establish_preselected(bool preselected[]) {

Are we going with `bool* preselected` now?

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/475#pullrequestreview-2252250037
PR Review Comment: https://git.openjdk.org/shenandoah/pull/475#discussion_r1725944837