RFR: 8338717: GenShen: Fix up some assertions [v2]

[Y. Srinivas Ramakrishna]

On Wed, 21 Aug 2024 19:18:31 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> In https://github.com/openjdk/jdk/pull/20395 Aleksey provided some suggestions for improving various assertions. This ticket gathers together several of those changes.
>> 
>> **Testing:**
>> - [x] GHA
>> - [x] jtreg:tier1
>> - [x] Codepipeline (investigating what appears to be an unrelated failure I encountered in testing)
>> - [x] SPECjbb w/GenShen (in progress)
>
> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into review_assert
>  - Unref variable deleted so as to eliminate -werror on Windows.
>  - Fix up some assertions etc. based on review feedback from Shipilev.

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/shenandoah/pull/478#issuecomment-2303289586