RFR: 8338780: GenShen: Fix up some comments [v2]

[Y. Srinivas Ramakrishna]

On Thu, 22 Aug 2024 21:02:45 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Could lines 114-118 be replaced with: assert(!cset->is_preselected(r->index(), comment)
>
> Thanks Kelvin! I'll convert this to a draft while I do a few experiments/investigations etc. along the lines of your suggestions... (Feel free to leave more comments here as necessary though; thanks!)

You are right Kelvin. I made the changes you suggested and will run them through all of the tests. Once that is done, I'll reopen this for a quick re-review. Thanks!

PS: (Archeology) The code was duplicated in https://github.com/openjdk/shenandoah/pull/292 and then the `fatal()` was added in https://github.com/openjdk/shenandoah/pull/318.
Interestingly, for the latter, I had a bunch of review feedback (of a general nature of refactoring) that I never quite got around to submitting, it seems (as I discovered when I loaded the PR in my browser; it's probably pretty stale by now).

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/484#discussion_r1730455087