RFR: 8338780: GenShen: Fix up some comments [v2]

Kelvin Nilsen kdnilsen at openjdk.org
Mon Aug 26 23:16:32 UTC 2024


On Mon, 26 Aug 2024 16:17:47 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> In https://github.com/openjdk/jdk/pull/20395 Aleksey provided some suggestions for improving various comments. This ticket gathers together several of those changes.
>> 
>> **Testing:** 
>> - [x] GHA
>> - [x] SPECjbb w/GenShen
>> - [x] jtreg:tier1
>> - [x] jtreg:hotspot_gc (one test fails with OOM in master as well as current branch; will investigate that separately)
>> - [ ] Codepipeline testing (in progress)
>
> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into review_changes_2
>  - Cleanup and get ready for testing & review.
>  - Sharpen assert for testing. Need more changes after this. Don't review
>    yet.
>  - Testing only: do not review this change.
>  - Merge branch 'master' into review_changes_2
>  - JDK-8338780 GenShen: Fix up some comments

Marked as reviewed by kdnilsen (Committer).

-------------

PR Review: https://git.openjdk.org/shenandoah/pull/484#pullrequestreview-2261808429


More information about the shenandoah-dev mailing list