RFR: 8337563: NMT: rename MEMFLAGS to MemFlag
Afshin Zafari
azafari at openjdk.org
Wed Aug 28 08:04:20 UTC 2024
On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemType` is much more suitable name.
>
> There is a bunch of other related cleanup that we can do, but I will leave for follow up issues such as [NMT: rename NMTUtil::flag to NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836)
- `MemTypeFlag` : 3
- `NMT::MemType` : 2
IMHO, `MemType` without NMT is a global name and possibly will be source of confusion in the code or by the developers.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2314608812
More information about the shenandoah-dev
mailing list