RFR: 8337563: NMT: rename MEMFLAGS to MemFlag

[Stefan Karlsson]

On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
> 
> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemType` is much more suitable name.
> 
> There is a bunch of other related cleanup that we can do, but I will leave for follow up issues such as [NMT: rename NMTUtil::flag to NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836)

I much prefer to see MemType, but I'm warming up to NMTCategory.

- MemType: Succinct - matches part of the code (E.g. the mt in mtGC)
- MemTypeFlag: Too many words for my preference.
- NMTCat: Meuw. :)
- NMTCategory: Parts of the code call these categories, so I'm not entirely against this.
- NMTGroup: "Group" is a new name for this that currently isn't reflected at all in the code.
- NMT_MemType: I think we should try get rid of names using this style.
- NMT::MemType: The `::` makes all function declarations noisier for very little benefit, IMO.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2318273393