RFR: 8339197: GenShen: Adding Generation and Evacuation Information JFR Logging [v3]

[William Kemper]

On Thu, 29 Aug 2024 20:59:17 GMT, Satyen Subramaniam <duke at openjdk.org> wrote:

>> Adding `ShenandoahEvacInfo` event and modifying existing logging for Concurrent Reset and Final Roots events to include generation for Generational Shenandoah GC.
>
> Satyen Subramaniam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removing extra ShenandoahEvacInfo, using size_t instead of uint

Minor nits about missing newlines and suggest comment saying that all size values are words or bytes.

src/hotspot/share/gc/shenandoah/shenandoahEvacInfo.hpp line 30:

> 28: #include "memory/allocation.hpp"
> 29: 
> 30: class ShenandoahEvacInfo : public StackObj {

Should we have a comment here saying that all size values are bytes or words?

src/hotspot/share/gc/shenandoah/shenandoahTrace.cpp line 54:

> 52:     e.commit();
> 53:   }
> 54: }

Missing newline.

src/hotspot/share/gc/shenandoah/shenandoahTrace.hpp line 42:

> 40: };
> 41: 
> 42: #endif

Missing newline.

-------------

Changes requested by wkemper (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/489#pullrequestreview-2273259903
PR Review Comment: https://git.openjdk.org/shenandoah/pull/489#discussion_r1739244805
PR Review Comment: https://git.openjdk.org/shenandoah/pull/489#discussion_r1739236779
PR Review Comment: https://git.openjdk.org/shenandoah/pull/489#discussion_r1739240500