RFR: 8328944: NMT reports "unknown" memory [v4]
Coleen Phillimore
coleenp at openjdk.org
Tue Dec 3 23:15:43 UTC 2024
On Thu, 21 Nov 2024 21:09:33 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> We use `mtNone` value in several functions default parameters, which may show up in NMT reports.
>>
>> We address this, by avoiding using `mtNone`.
>>
>> This fix only addresses the cases covered by the issue. I am not trying to replace every single `mtNone` here, but eventually the goal would be to do just that.
>>
>> Testing: passes MARCH5 tier1-5
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>
> Stefan's feedback
Yes, this is much better to require the mt parameter to be passed down rather than fixing it up after the memory reservation, and having some code miss doing it.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21843#pullrequestreview-2476944377
More information about the shenandoah-dev
mailing list