RFR: 8345423: Shenandoah: Parallelize concurrent cleanup [v6]

Xiaolong Peng xpeng at openjdk.org
Thu Dec 5 18:41:47 UTC 2024


On Thu, 5 Dec 2024 18:21:59 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Ensure atomicity when access region state
>>  - Bug fix and move is_trash test into try_recycle
>
> src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp line 629:
> 
>> 627:     _recycling.unset();
>> 628:   } else {
>> 629:     while (_recycling.is_set()) {
> 
> Why are adding this? Won't this make the calling worker thread wait on another worker to recycle the region?

hmm,  didn't include this intentionally, forgot to remove it from commit, sorry I'll remove it, thanks for catching it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22538#discussion_r1871911601


More information about the shenandoah-dev mailing list