RFR: 8344593: GenShen: Review of ReduceInitialCardMarks [v4]

Aleksey Shipilev shade at openjdk.org
Thu Dec 5 19:50:26 UTC 2024


On Thu, 5 Dec 2024 19:47:00 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Fix documentation comment, and add an assertion check upon slowpath allocation.
>> 
>> I also checked the impact of +/-ReduceInitialCardMarks on GenShen using SPECjbb and didn't see any difference. We've left it enabled by default because less card marking is better in this case.
>
> Y. Srinivas Ramakrishna has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Demorganization of clause in assert per review feedback

Still fine.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22507#pullrequestreview-2482712946


More information about the shenandoah-dev mailing list