RFR: 8344593: GenShen: Review of ReduceInitialCardMarks [v3]

[Y. Srinivas Ramakrishna]

On Wed, 4 Dec 2024 23:45:07 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Fix documentation comment, and add an assertion check upon slowpath allocation.
>> 
>> I also checked the impact of +/-ReduceInitialCardMarks on GenShen using SPECjbb and didn't see any difference. We've left it enabled by default because less card marking is better in this case.
>
> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into ricm
>  - virtual -> override missed in previous delta.
>    Fix zero build (ReduceInitialCardMarks is defined only in
>    JVMCI/Compiler2)
>  - virtual -> override in derived class ShenandoahBarrierSet.
>  - Refine previous change and future-proof ReduceInitialCardMarks for
>    GenShen.
>  - Fix up documentation comment.

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22507#issuecomment-2521256371