RFR: 8345647: Fix recent NULL usage backsliding in Shenandoah
Aleksey Shipilev
shade at openjdk.org
Tue Dec 10 15:01:13 UTC 2024
On Mon, 9 Dec 2024 15:29:56 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:
> Hi all,
>
> This PR addresses [8345647](https://bugs.openjdk.org/browse/JDK-8345647) addressing uses of `NULL` in Shenandoah. These should be replaced to `null`.
>
> I verified where those uses are with:
> `git show <commit-id> --name-only | while read file; do echo "File: $file"; git diff <commit-id> -- "$file" | grep -n -F 'NULL'; done`
>
> The relevant output:
>
> File: src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.cpp
> 9:- // No need for post barrier if storing NULL
> File: src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp
> 9:- // must be either an oop or NULL
> 12: if (t == TypePtr::NULL_PTR || t == Type::TOP)
>
>
> Changes affect comments only.
>
> Thanks,
> Sonia
Well, it is not technically a `NULL -> nullptr` changes we handle with PRs like these, but I guess it is good to have a consistent wording.
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22647#pullrequestreview-2491632690
More information about the shenandoah-dev
mailing list