RFR: 8342214: GenShen: Reduce code duplication in shFreeSet with iterator abstraction

Y. Srinivas Ramakrishna ysr at openjdk.org
Wed Dec 11 20:04:10 UTC 2024


On Wed, 11 Dec 2024 18:48:01 GMT, William Kemper <wkemper at openjdk.org> wrote:

> These were almost all clean. All pipeline tests have passed.

LGTM based on a cursory glance at the changes, the correctness of the testing, and the clean-ness of the backports.

I did a cursory check and it looks good. As regards:

> Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit.

May be check if that works better and quiets the complaints of the robot overlords? I am guessing `\backport` takes only a single parameter, and multiple `\backport`s can't be composed/nested.

Not sure what the right process is that is recommended here. May be @shipilev has a suggestion?

-------------

Marked as reviewed by ysr (Committer).

PR Review: https://git.openjdk.org/shenandoah-jdk21u/pull/143#pullrequestreview-2496718939
PR Comment: https://git.openjdk.org/shenandoah-jdk21u/pull/143#issuecomment-2536991385


More information about the shenandoah-dev mailing list