RFR: 8345655: Move reservation code out of ReservedSpace [v2]

Afshin Zafari azafari at openjdk.org
Fri Dec 13 18:45:37 UTC 2024


On Fri, 13 Dec 2024 13:23:14 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The ReservedSpace class and its friends has a dual functionality of describing a reserved memory region AND it also reserves memory. I would like to split this so that the ReservedSpace classes only acts as data carrier about reserved memory and then have a more explicit API for reserving memory and baking a ReservedSpace given the outcome of the reservation.
>> 
>> See the first comment for the full description:
>
> Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into reserved_space_rewrite
>  - Fix comment
>  - 8345655: Move reservation code out of ReservedSpace

Thanks for this work.
I found no problem in logic and replacements. However, some Copyright years have to be updated:

- New files should have only one year in Copyright text:
`memoryReserver.?pp`
`reservedSpace.?pp`

- Changed files:
`cds/dynamicArchive.hpp`
`gc/g1/g1PageBasedVirtualSpace.hpp`
`gc/parallel/psVirtualspace.hpp`
`gc/shared/generationCounters.cpp` + `.hpp`
`memory/metaspace/virtualSpaceNode.hpp`

-------------

PR Review: https://git.openjdk.org/jdk/pull/22712#pullrequestreview-2502915973


More information about the shenandoah-dev mailing list