RFR: 8324649: Shenandoah: refactor implementation of free set [v6]
Kelvin Nilsen
kdnilsen at openjdk.org
Sat Feb 3 00:01:04 UTC 2024
On Thu, 1 Feb 2024 02:06:12 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename and comments for _capacity_of and _used_by
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 60:
>
>> 58: size_t _rightmosts[NumPartitions];
>> 59:
>> 60: // Allocation for humongous objects needs to find regions that are entirely empty. For each partion p, _leftmosts[p]
>
> `_leftmosts_empty` and, similarly, `_rightmosts_empty`.
Oops. Thanks.
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 63:
>
>> 61: // represents the first region belonging to this partition that is completely empty and _rightmosts[p] represents the
>> 62: // last region that is completely empty. If there are no completely empty regions in this partition, this is represented
>> 63: // by canonical [_max, 0].
>
> ... is no completely empty region in this partition id, ...
>
>
>
> ... the canonical ...
Thanks. fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1476881647
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1476881947
More information about the shenandoah-dev
mailing list