RFR: 8324649: Shenandoah: refactor implementation of free set [v4]
Kelvin Nilsen
kdnilsen at openjdk.org
Sat Feb 3 14:04:03 UTC 2024
On Wed, 31 Jan 2024 17:33:17 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> The problem happens when leftmost is zero. If we decrement idx beyond zero, we would get MAXINT rather than -1, so the test that idx >= leftmost is always true and loop never terminates... I think I discovered this the hard way... :(
>
> `ssize_t` is signed, unlike `size_t` which is unsigned.
Thanks for clarifying. I did know ssize_t. I'm adjusting the code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1477069379
More information about the shenandoah-dev
mailing list