RFR: 8324649: Shenandoah: refactor implementation of free set [v6]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Feb 7 18:56:57 UTC 2024
On Thu, 1 Feb 2024 06:17:25 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename and comments for _capacity_of and _used_by
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 95:
>
>> 93: void make_free(size_t idx, ShenandoahFreeSetPartitionId which_partition, size_t region_capacity);
>> 94:
>> 95: // Place region idx into free partition new_partition. Requires that idx is currently not NotFree.
>
> Include semantics of region_capacity in comment, e.g.:
>
>
> // Move region idx, with region_capacity bytes of available free space,
> // from the NotFree partition to the free partition new_partition.
Thanks. I've adjusted this comment to make the intent more clear.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1481941805
More information about the shenandoah-dev
mailing list