RFR: 8322630: Remove ICStubs and related safepoints [v6]

Erik Österlund eosterlund at openjdk.org
Fri Feb 9 09:32:01 UTC 2024


On Thu, 8 Feb 2024 09:25:33 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ARM32 fixes
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 1016:
> 
>> 1014:   Register tmp1 = rscratch1;
>> 1015:   Register tmp2 = r10;
>> 1016: 
> 
> It would be nice if we could still call `verify_oop(receiver)` here, but I see that would complicate `ic_check_size()`.

Yeah I thought the same. As it's important for correctness that ic_check_size is accurate, I was hoping to have as few different modes in it as possible.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484070401


More information about the shenandoah-dev mailing list