RFR: 8322630: Remove ICStubs and related safepoints [v8]

[Erik Österlund]

On Thu, 8 Feb 2024 21:21:59 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/code/compiledIC.hpp
>>   
>>   Co-authored-by: Thomas Schatzl <59967451+tschatzl at users.noreply.github.com>
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 770:
> 
>> 768:     // Method might have been compiled since the call site was patched to
>> 769:     // interpreted; if that is the case treat it as a miss so we can get
>> 770:     // the call site corrected.
> 
> This comment is still relevant, isn't it?

Unfortunately it is. I think it should be done in the subsequent patch_callers_callsite that has this exact same purpose for code dispatching through the VEP. But I think it's outside of scope for this PR to change that. I'm putting the comment back.

> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 1555:
> 
>> 1553:   __ far_jump(RuntimeAddress(SharedRuntime::get_ic_miss_stub()));
>> 1554: 
>> 1555:   // Verified entry point must be aligned
> 
> Keep this comment?

Yeah, will do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484067761
PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484070144