RFR: 8322630: Remove ICStubs and related safepoints [v6]

Erik Österlund eosterlund at openjdk.org
Fri Feb 9 09:43:10 UTC 2024


On Fri, 9 Feb 2024 01:38:00 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ARM32 fixes
>
> src/hotspot/share/runtime/vmStructs.cpp line 217:
> 
>> 215:   volatile_nonstatic_field(CompiledICData,     _speculated_klass,                             uintptr_t)                             \
>> 216:   nonstatic_field(CompiledICData,              _itable_defc_klass,                            Klass*)                                \
>> 217:   nonstatic_field(CompiledICData,              _itable_refc_klass,                            Klass*)                                \
> 
> I don't think it makes sense to export these fields and types until SA is changed to make use of them.

Good point. I thought at least Graal needs them, but they have their own VM structs file where they are exposed. I'll remove this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484082651


More information about the shenandoah-dev mailing list